Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple prometheus and promtail targets #369

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Allow multiple prometheus and promtail targets #369

merged 2 commits into from
Jan 17, 2025

Conversation

simcod
Copy link
Contributor

@simcod simcod commented Jan 15, 2025 •
edited
Loading

Description

This PR allows to configure multiple targets for Prometheus and Promtail.

Required Actions

For Prometheus, the ansible variables: `prometheus_remote_write_url`, `prometheus_remote_write_basic_auth_username` and `prometheus_remote_write_basic_auth_password` have been removed. Please use the new variable `prometheus_remote_write` instead for configuring the complete remote write target, e.g. with `basic_auth`. 
For Promtail, the ansible variables: `promtail_loki_push_endpoint`, `promtail_loki_basic_auth_username` and `promtail_loki_basic_auth_password` have been removed. Please use the new variable `promtail_clients` instead.

@simcod simcod marked this pull request as ready for review January 15, 2025 08:57
@simcod simcod requested a review from a team as a code owner January 15, 2025 08:57
robertvolkmann
robertvolkmann requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is noteworthy.

partition/roles/monitoring/prometheus/README.md Outdated Show resolved Hide resolved
partition/roles/promtail/README.md Outdated Show resolved Hide resolved
@simcod simcod requested a review from robertvolkmann January 15, 2025 11:36
@robertvolkmann
Copy link
Contributor

Please add a "Required Actions" section like in #337

@Gerrit91 Gerrit91 merged commit 724c4d1 into master Jan 17, 2025
1 check passed
@Gerrit91 Gerrit91 deleted the monitoring-multiple-remote-write-targets branch January 17, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertvolkmann robertvolkmann robertvolkmann approved these changes

@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simcod @robertvolkmann @Gerrit91