Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in meilisearch list function #153

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Honigeintopf
Copy link
Collaborator

I have no idea why, but not all changes are reflect in git.
I changed more than the lines shown.

Fixed bug by creating new query for every entry in the index, instead of using last index, which leads to overwriting.

No idea why, but not all changes are reflect in git
@Honigeintopf Honigeintopf requested a review from a team as a code owner September 4, 2024 11:38
@Honigeintopf Honigeintopf linked an issue Sep 4, 2024 that may be closed by this pull request
@Honigeintopf Honigeintopf requested a review from vknabel September 4, 2024 11:38
Copy link
Contributor

@vknabel vknabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof. Good catch! Although just repeating the same query over and over was somewhat nice, too. :D

(regarding currently visible changes)

@vknabel vknabel self-requested a review September 4, 2024 11:52
@vknabel vknabel merged commit c77bf9c into master Sep 4, 2024
2 checks passed
@vknabel vknabel deleted the bug-in-meilisearch-list-function branch September 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in for loop for meilisearch List Function
2 participants