fix(lint): explicitly ignored ctx

metal-stack · Jul 26, 2024 · 4856de9 · 4856de9
1 parent 14b8a91
commit 4856de9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/healthstatus/async-check.go b/healthstatus/async-check.go
@@ -40,7 +40,7 @@ func (c *AsyncHealthCheck) ServiceName() string {
 func (c *AsyncHealthCheck) Check(context.Context) (HealthResult, error) {
 	c.log.Debug("checked async")
 	if c.ticker == nil {
-		c.Start(context.Background())
+		c.Start(context.Background()) //nolint:contextcheck
 	}
 	return c.current.Status, c.current.Err
 }
@@ -97,10 +97,6 @@ func (r *AsyncHealthCheck) ForceUpdateStatus(ctx context.Context) error {
 
 func (r *AsyncHealthCheck) updateStatus(ctx context.Context) error {
 	r.log.Info("evaluating current service health statuses")
-	if ctx == nil {
-		ctx = context.Background()
-	}
-
 	ctx, cancel := context.WithTimeout(ctx, r.healthCheckInterval/2)
 	defer cancel()
 

diff --git a/healthstatus/deferred-error-check.go b/healthstatus/deferred-error-check.go
@@ -35,7 +35,7 @@ func (c *DeferredErrorHealthCheck) Check(ctx context.Context) (HealthResult, err
 	if err == nil {
 		c.errorCountSinceSuccess = 0
 		c.lastSuccess = state
-		return status, err
+		return status, nil
 	}
 	c.errorCountSinceSuccess++
 	if c.errorCountSinceSuccess > c.maxIgnoredErrors {