Add Service in order to generate correct NetworkPolicies #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. I removed accidentally the whole service object instead of only parts of it: |
|
From what I can see in the provider-aws repo, it only differs because it supports older/deprecated configs and has a webhooks. So the smaller Service here should be good, wdyt? |
|
I will release this PR together with a bump to Gardener 1.95 in the coming days. |
robertvolkmann
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The extension is discovered by the
PodMonitor/seed-extensions, but cannot be scraped byseed-prometheusbecause there are no ingress NetworkPolicies that allow it.This PR adds the Service in accordance with the gardener documentation
Release Notes
Noteworthy