Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information regarding gardener and metal-stack #233

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simcod
Copy link
Contributor

@simcod simcod commented Nov 25, 2024

Description

Adds more information regarding Gardener on / with metal-stack.

@metal-robot
Copy link
Contributor

metal-robot bot commented Nov 25, 2024

Thanks for contributing a pull request to the metal-stack docs!

A rendered preview of your changes will be available at: https://docs.metal-stack.io/previews/PR233/

@simcod simcod marked this pull request as ready for review December 9, 2024 07:47
@simcod simcod requested a review from a team as a code owner December 9, 2024 07:47
@simcod simcod requested a review from majst01 December 9, 2024 07:47

**Garden Cluster**

A dedicated Kubernetes cluster that the Gardener control plane runs in. The Kubernetes cluster can be setup e.g. with Kubespray.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not mention kubespray here because this is not our favorite.


- GCP/GKE
- metalstack.cloud
- Kubespray
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, please do not mention kubespray here

docs/src/overview/kubernetes.md Show resolved Hide resolved
- etcd
- kube-controller-manager

More details about the value of a virtual garden can be found in the description of [garden-setup](https://github.com/gardener/garden-setup/?tab=readme-ov-file#concept-the-virtual-cluster).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's not so good to reference garden-setup here because it's outdated and not maintained. They use the Gardener operator now to spin up the virtual garden. So maybe try to reference the operator: https://github.com/gardener/gardener/blob/master/docs/concepts/operator.md

The agent gets deployed in every seed cluster.

**Soil**
The soil cluster is the host for other seeds. It is the initital seed cluster, that is used for spinning up shooted seeds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A soil cluster is a cluster in which the Gardenlet was deployed without using Gardener itself / the shooted seed functionality.


### metal-stack Setup

> **Attention:** Bootstrapping a meta-stack partition is out of scope and need to be done before focusing on the relationship between metal-stack and Gardener. This guide assumes a metal-stack partition (servers, switches, network, ...) is already in place.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Attention:** Bootstrapping a meta-stack partition is out of scope and need to be done before focusing on the relationship between metal-stack and Gardener. This guide assumes a metal-stack partition (servers, switches, network, ...) is already in place.
> **Attention:** Bootstrapping a metal-stack partition is out of scope and need to be done before focusing on the relationship between metal-stack and Gardener. This guide assumes a metal-stack partition (servers, switches, network, ...) is already in place.

@simcod
Copy link
Contributor Author

simcod commented Dec 11, 2024

Thanks for the feedback. I changed some parts and the overall structure. Further feedback welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants