Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Capabilities Plugin (XEP-0115) #46

Merged
merged 3 commits into from
Jan 5, 2012
Merged

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Dec 30, 2011

Hi,

I developed the entity capabilities plugin on top of the disco plugin.
The recently added sha-1.js of strophe.js is required in order for the plugin to work.

  • Michael

@flosse
Copy link
Collaborator

flosse commented Dec 30, 2011

Hi Michael,
thanks for your work!
Did you have a look at the existing CAPS plugin (https://github.com/flosse/strophejs-plugins/tree/master/caps)?
However, Yours looks pretty good and much more complete.
Which disco plugin do you use (there are two)?

@mweibel
Copy link
Contributor Author

mweibel commented Dec 30, 2011

Hi flosse,

oh, no didn't see yours :) Could have saved me some time ;)
Well yours seem to add some adapter-methods for the disco-plugin. Maybe that's not a bad idea.
Also using the module pattern seems to be a good idea.

I didn't see two (although I saw your open issue).. I use this one which is the other one?

I'll need to do some fixes, at a 2nd glance I saw some missing this's :)

@flosse
Copy link
Collaborator

flosse commented Jan 5, 2012

I updated #42 so that it's more visible that there are two disco plugins ;-)

flosse added a commit that referenced this pull request Jan 5, 2012
Entity Capabilities Plugin (XEP-0115)
@flosse flosse merged commit 1a386a1 into metajack:master Jan 5, 2012
@flosse
Copy link
Collaborator

flosse commented Jan 5, 2012

... and if you like to have some fun you could write some tests and merge the two caps plugins ;-) => #47

@mweibel
Copy link
Contributor Author

mweibel commented Jan 5, 2012

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants