Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update resourcelanguage from code to text #245

Open
wants to merge 2 commits into
base: 3.12.x
Choose a base branch
from
Open

update resourcelanguage from code to text #245

wants to merge 2 commits into from

Conversation

wangf1122
Copy link
Contributor

The resource language currents is using code instead of actual text as label. Here is the updated view from the user.

image

@wangf1122 wangf1122 mentioned this pull request Oct 25, 2021
Open
4 tasks
ianwallen
ianwallen reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ianwallen ianwallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anglaise should be Anglais

src/main/config/codelist/local/thesauri/theme/GC_Resource_Languages.rdf Outdated Show resolved Hide resolved
src/main/config/codelist/local/thesauri/theme/GC_Resource_Languages.rdf Outdated Show resolved Hide resolved
@ianwallen ianwallen self-requested a review October 27, 2021 12:06
ianwallen
ianwallen reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@ianwallen ianwallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good however based on the following comment

#95 (comment)

We are not getting the results that are expected.

So we have to wait until the issues identified in that comment are resolved before we can approve this PR.

@ianwallen ianwallen added this to the 3.12.2 milestone Oct 29, 2021
@josegar74 josegar74 modified the milestones: 3.12.2, 3.12.3, 3.12.4 Jan 25, 2022
@josegar74 josegar74 modified the milestones: 3.12.4, 3.12.6 May 23, 2022
@josegar74 josegar74 modified the milestones: 3.12.6, 3.12.7 Jun 22, 2022
@ianwallen ianwallen modified the milestones: 3.12.7, 3.12.8 Oct 5, 2022
@josegar74 josegar74 modified the milestones: 3.12.8, 3.10.9 Dec 12, 2022
@ianwallen ianwallen modified the milestones: 3.10.9, 3.12.10 Mar 13, 2023
@josegar74 josegar74 modified the milestones: 3.12.10, 3.12.11 May 10, 2023
@josegar74 josegar74 modified the milestones: 3.12.11, 3.12.12 Oct 4, 2023
@josegar74 josegar74 modified the milestones: 3.12.12, 3.12.13 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianwallen ianwallen ianwallen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.13
Development

Successfully merging this pull request may close these issues.
3 participants
@wangf1122 @ianwallen @josegar74