Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation / Review readme #28

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Documentation / Review readme #28

merged 6 commits into from
Dec 11, 2024

Conversation

fxprunayre
Copy link
Contributor

No description provided.

Copy link
Collaborator

@joachimnielandt joachimnielandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a question remaining on line 193:

Q:
* check default view using `default='true'`. What happens if more than one default?
* check which view to load by default? Maybe see EditorController.js

Another one on line 303:

Q: Check how to enable/disable schematron rules for a profile with an example

I remember Olivia having an example here - I'll try to fish it up and perhaps also include it in the VL fork for reference.

README.md Outdated Show resolved Hide resolved
@fxprunayre
Copy link
Contributor Author

  • check default view using default='true'. What happens if more than one default?

It fails. Improved in geonetwork/core-geonetwork#8548

  • check which view to load by default? Maybe see EditorController.js

With the PR above, we can put the first default view (with or without condition) to use first and it should work.

The order in the menu is based on the order in config-editor
image

Maybe we can remove fromRoot which was more for dev purpose and we can also hide xml view for non admin ?

@joachimnielandt
Copy link
Collaborator

Hiding fromRoot seems reasonable, but I think a lot of our editors are still accessing the XML view from time to time. I would keep that available, for sure.

@fxprunayre fxprunayre merged commit dfbb585 into main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants