Replacing "IRC" with "Chat" or "ChatBrainz" #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for tackling this. I'll pay attention to it once the back-to-aback summits have stopped their toll on me. |
|
No rush, take it easy! |
reosarevok
requested changes
Oct 11, 2024
As mentioned by mayhem at the summit, updated IRC references to ChatBrainz references and changed the relevant links. Also added a social media section, as they are in the footer and why not. Blog doesn't 100% fit the header, but I think this is the best place for it.
I think Chat is a big enough MeB channel to be in the footer for 'Contact Us', especially compared to Insta etc.
Now that we have team members spread across a few chat channels (Mainly Matrix and IRC) I have changed references to "IRC" to the hopefully-future proof "Chat"
Replaced "IRC" with "Chat"
These are apparently built-in with 3.1 and having it like this was causing a crash when using pybabel.
Seems this hadn't been done since 2017??? So a lot of unrelated changes in here, but probably fine.
These might have worked with underscore back in 2017 or whatnot but now they need a hyphen.
|
I think this is now ready but one of @mayhem or @amCap1712 should take a quick look at least. |
mayhem
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by mayhem at the summit, updated "IRC" references to "Chat" or "ChatBrainz" references and changed the relevant links.
Will need testing, sorry, but hopefully this is most of the work done.