-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the text on the profile page for commercial users #445
Conversation
can get confused as to what waiting status means, so lets spell it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible to me.
Co-authored-by: Adam James <[email protected]>
Thanks @atj! |
</p> | ||
<p> | ||
{{ _('Reason:') }} | ||
<h3>Limited/no data use permission granted</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it the i18n stuff (_('…')
) removed on purpose, on this line and a few others below ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this site is not easily translatable, for a number of reasons. I originally didn't want i18n support for the site, but it was implemented anyway. Its just in our way, so I'm not bothering with it when I make changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we will certainly need i18n support for the parts of the site that will be used for standard users to log in and whatnot, especially once we move to MeB accounts. That said, the business-facing bits being all English make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its the business and more importantly legal aspects that are super $$$ to fully translate. I'm totally ok, for having the login pages localized.
People can get confused as to what waiting status means, so lets spell it out and make the page a little more clear and readable overall.