Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the text on the profile page for commercial users #445

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Nov 9, 2023

People can get confused as to what waiting status means, so lets spell it out and make the page a little more clear and readable overall.

can get confused as to what waiting status means, so lets spell it out.
Copy link

github-actions bot commented Nov 9, 2023

Test Results

67 tests  ±0   67 ✔️ ±0   8s ⏱️ -6s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit fda3556. ± Comparison against base commit 99097a1.

♻️ This comment has been updated with latest results.

Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me.

@mayhem
Copy link
Member Author

mayhem commented Nov 9, 2023

Thanks @atj!

@mayhem mayhem merged commit 0303fc6 into master Nov 9, 2023
2 checks passed
@mayhem mayhem deleted the improve-data-use-text branch November 9, 2023 13:45
</p>
<p>
{{ _('Reason:') }}
<h3>Limited/no data use permission granted</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it the i18n stuff (_('…')) removed on purpose, on this line and a few others below ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this site is not easily translatable, for a number of reasons. I originally didn't want i18n support for the site, but it was implemented anyway. Its just in our way, so I'm not bothering with it when I make changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we will certainly need i18n support for the parts of the site that will be used for standard users to log in and whatnot, especially once we move to MeB accounts. That said, the business-facing bits being all English make sense to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the business and more importantly legal aspects that are super $$$ to fully translate. I'm totally ok, for having the login pages localized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants