Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI unit tests results workflow #495

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

MonkeyDo
Copy link
Member

I noticed this test workflow has been consistently failing* even thought the testing step succeeds. The action that is supposed to publish the test results is failing due to permissions issues.

I'm now adding the required permissions to allow the workflow to write checks and comments on pull requests, as well as updating to a newer version of the action.

Adding the required permissions to allow the workflow to write checks on pull requests*, as well as updating to a newer version of the workflow 

* see failures like so: https://github.com/metabrainz/critiquebrainz/actions/runs/6559728119/job/17815889047?pr=494#step:9:31
@MonkeyDo MonkeyDo requested a review from anshg1214 October 20, 2023 13:01
@github-actions
Copy link

Test Results

201 tests   201 ✔️  11m 59s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit e60d84f.

@MonkeyDo
Copy link
Member Author

Test Results

201 tests   201 ✔️  11m 59s ⏱️     1 suites      0 💤     1 files        0

Results for commit e60d84f.

The proof is in the pudding :) ^

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not seen the PR earlier and removed the failing step altogether because we didn't use it much anyway. LGTM, Thanks.

@amCap1712 amCap1712 merged commit 5ce51dd into master Oct 31, 2023
1 check passed
@amCap1712 amCap1712 deleted the update-CI-test-publisher-2 branch October 31, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants