Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-448: Implemented new footer design #491

Merged
merged 4 commits into from
May 22, 2024

Conversation

phw
Copy link
Member

@phw phw commented Sep 19, 2023

Dipping my toes into the CB code :)

This implements the new footer as designed by @Aerozol in CB-448. The implementation was mostly directly taken from Picard's website as implemented in metabrainz/picard-website#264 and adapted to the code and content of CB.

Here are some screenshots:

Front page, full width:
grafik

SM size:

grafik

XS size:

grafik

@Aerozol
Copy link
Contributor

Aerozol commented Sep 20, 2023

Screenshots look great!

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for dipping your toes :D

As we discussed IRL, here's a couple of modifications we thought about:

  1. adding a bit of padding at the bottom of the top part of the footer:
    Before:
image After: image
  1. Remove the Cover Art Archive in the fellow projects links

  2. we talked about rethinking the bottom three elements ("OSS geek", MeB logo, "Found an issue") to use a flexbox layout, which would allow us to center content and reflow the elements a bit more precisely (including reordering the elements depending on screen size, instead of hiding them on small sizes)

@phw
Copy link
Member Author

phw commented Nov 4, 2023

@MonkeyDo I finally sat down and worked on this again. The line now provides now an equal gap top and bottom and I have used a flexbox for the links below the lines. This is how it looks like at the breakpoint sizes:

@screen-lg:
grafik

@screen-md:
grafik

@screen-sm:
grafik

@screen-xs:
grafik

@phw phw force-pushed the CB-448-new-footer branch from ebcce25 to bed4078 Compare November 4, 2023 16:58
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks @phw for implementing the better footer !

@MonkeyDo MonkeyDo merged commit a1b1200 into metabrainz:master May 22, 2024
2 checks passed
@MonkeyDo
Copy link
Member

Sorry I frogot about this PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants