-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-448: Implemented new footer design #491
Conversation
Screenshots look great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for dipping your toes :D
As we discussed IRL, here's a couple of modifications we thought about:
- adding a bit of padding at the bottom of the top part of the footer:
Before:
-
Remove the Cover Art Archive in the fellow projects links
-
we talked about rethinking the bottom three elements ("OSS geek", MeB logo, "Found an issue") to use a flexbox layout, which would allow us to center content and reflow the elements a bit more precisely (including reordering the elements depending on screen size, instead of hiding them on small sizes)
@MonkeyDo I finally sat down and worked on this again. The line now provides now an equal gap top and bottom and I have used a flexbox for the links below the lines. This is how it looks like at the breakpoint sizes: |
ebcce25
to
bed4078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks @phw for implementing the better footer !
Sorry I frogot about this PR 😅 |
Dipping my toes into the CB code :)
This implements the new footer as designed by @Aerozol in CB-448. The implementation was mostly directly taken from Picard's website as implemented in metabrainz/picard-website#264 and adapted to the code and content of CB.
Here are some screenshots:
Front page, full width:
SM size:
XS size: