Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add single create bundle command #728

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

jimmidyson
Copy link
Contributor

This handles both image and helm charts config files so can be used
to replace both of the individual subcommands, which are now deprecated.

@jimmidyson jimmidyson requested a review from mhrabovcin May 23, 2024 12:02
Copy link
Contributor

github-actions bot commented May 23, 2024

Unit test results

100 tests  ±0   100 ✅ ±0   0s ⏱️ ±0s
 25 suites +1     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 52b748d. ± Comparison against base commit 4b2abb0.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
imagebundle ‑ TestEmptyPS
imagebundle ‑ TestEmptyPSValue
imagebundle ‑ TestPS
imagebundle ‑ TestPSAppend
imagebundle ‑ TestPSAsSliceValue
imagebundle ‑ TestPSDefault
imagebundle ‑ TestPSGetSlice
imagebundle ‑ TestPSInvalidPlatform
imagebundle ‑ TestSSCalledTwice
imagebundle ‑ TestSSWithComma
…
flags ‑ TestEmptyPS
flags ‑ TestEmptyPSValue
flags ‑ TestPS
flags ‑ TestPSAppend
flags ‑ TestPSAsSliceValue
flags ‑ TestPSDefault
flags ‑ TestPSGetSlice
flags ‑ TestPSInvalidPlatform
flags ‑ TestSSCalledTwice
flags ‑ TestSSWithComma
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 23, 2024

e2e test results

33 tests  ±0   30 ✅ ±0   1m 36s ⏱️ -20s
 2 suites ±0    3 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 52b748d. ± Comparison against base commit 4b2abb0.

♻️ This comment has been updated with latest results.

This handles both image and helm charts config files so can be used
to replace both of the individual subcommands, which are now deprecated.
@jimmidyson jimmidyson force-pushed the jimmi/single-create branch from ef9e579 to 52b748d Compare May 23, 2024 12:10
@jimmidyson jimmidyson enabled auto-merge (squash) May 23, 2024 12:16
@jimmidyson jimmidyson merged commit 3599823 into main May 23, 2024
11 checks passed
@jimmidyson jimmidyson deleted the jimmi/single-create branch May 23, 2024 12:17
jimmidyson pushed a commit that referenced this pull request May 23, 2024
🤖 I have created a release *beep* *boop*
---


## 1.14.0 (2024-05-23)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Add single create bundle command by @jimmidyson in
#728
### Other Changes
* Replace unpinned actions with pinned action by @minder-by-stacklok in
#705
* build: Ignore long lines for commit shas by @jimmidyson in
#717
* build: Update all tools by @jimmidyson in
#718
* ci: New org for backport action by @jimmidyson in
#719
* test(e2e): Specify architecture for test images in e2e by @jimmidyson
in #727
* ci: Fix up permissions for release conventional labels job by
@jimmidyson in #729
* ci: Remove redundant env var by @jimmidyson in
#730

## New Contributors
* @minder-by-stacklok made their first contribution in
#705

**Full Changelog**:
v1.13.4...v1.14.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: mesosphere-actions-pr-bot[bot] <157582460+mesosphere-actions-pr-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants