fix: Support published Helm charts with different name format #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test results100 tests 100 ✅ 0s ⏱️ Results for commit 810aa99. ♻️ This comment has been updated with latest results. |
e2e test results33 tests 30 ✅ 1m 52s ⏱️ Results for commit 810aa99. ♻️ This comment has been updated with latest results. |
Currently `minthegap create helm-bundle` fails if the chart published in
the helm repo has a different name to the expected format
`<chartName>-<chartVersion>.tgz`. An example that hit this issue is the NFD
chart that is published with the name
`<chartName>-chart-<chartVersion>.tgz`.
This commit fixes the issue by first finding the download URL from the
Helm repo index and then using the existing `GetChartFromURL` function
to download the chart. This already correctly uses the basename of the
published chart file and hence doesn't hit the above issue.
Tested to be working:
```bash
$ cat repos.yaml
repositories:
nfd:
repoURL: https://kubernetes-sigs.github.io/node-feature-discovery/charts/
charts:
node-feature-discovery:
- 0.15.2
$ ./dist/mindthegap_darwin_arm64/mindthegap create helm-bundle --helm-charts-file=repos.yaml --overwrite
✓ Parsing Helm chart bundle config
✓ Creating temporary OCI registry directory
✓ Starting temporary OCI registry
✓ Creating temporary chart storage directory
✓ Fetching Helm chart node-feature-discovery (versions [0.15.2]) from nfd
(https://kubernetes-sigs.github.io/node-feature-discovery/charts/)
✓ Archiving Helm charts to helm-charts.tar
$ ./dist/mindthegap_darwin_arm64/mindthegap serve bundle --bundle helm-charts.tar &
✓ Creating temporary directory
✓ Unarchiving image bundle "helm-charts.tar"
✓ Parsing Helm charts bundle config
✓ Creating Docker registry
Listening on 127.0.0.1:58639
$ crane ls 127.0.0.1:58783/charts/node-feature-discovery
0.15.2
```
jimmidyson
force-pushed
the
jimmi/fix-download-from-different-chart-name
branch
from
c804391 to
810aa99
Compare
faiq
approved these changes
Apr 24, 2024
Merged
faiq
pushed a commit
that referenced
this pull request
Apr 24, 2024
🤖 I have created a release *beep* *boop* --- ## 1.13.4 (2024-04-24) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: Support published Helm charts with different name format by @jimmidyson in #695 **Full Changelog**: v1.13.3...v1.13.4 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: mesosphere-actions-pr-bot[bot] <157582460+mesosphere-actions-pr-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
mindthegap create helm-bundlefails if the chart published inthe helm repo has a different name to the expected format
<chartName>-<chartVersion>.tgz. An example that hit this issue is the NFDchart that is published with the name
<chartName>-chart-<chartVersion>.tgz.This commit fixes the issue by first finding the download URL from the
Helm repo index and then using the existing
GetChartFromURLfunctionto download the chart. This already correctly uses the basename of the
published chart file and hence doesn't hit the above issue.
Tested to be working:
$ cat repos.yaml repositories: nfd: repoURL: https://kubernetes-sigs.github.io/node-feature-discovery/charts/ charts: node-feature-discovery: - 0.15.2 $ ./dist/mindthegap_darwin_arm64/mindthegap create helm-bundle --helm-charts-file=repos.yaml --overwrite ✓ Parsing Helm chart bundle config ✓ Creating temporary OCI registry directory ✓ Starting temporary OCI registry ✓ Creating temporary chart storage directory ✓ Fetching Helm chart node-feature-discovery (versions [0.15.2]) from nfd (https://kubernetes-sigs.github.io/node-feature-discovery/charts/) ✓ Archiving Helm charts to helm-charts.tar $ ./dist/mindthegap_darwin_arm64/mindthegap serve bundle --bundle helm-charts.tar & ✓ Creating temporary directory ✓ Unarchiving image bundle "helm-charts.tar" ✓ Parsing Helm charts bundle config ✓ Creating Docker registry Listening on 127.0.0.1:58639 $ crane ls 127.0.0.1:58783/charts/node-feature-discovery 0.15.2