fix: Reload registry TLS certificate when it is updated on the file s…

…ystem (#805)

Watch the filesystem for changes to the certificate, and reload when it
is updated.

Introduces a dependency on
https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/certwatcher. This
does not appear to impact the executable size.

The first commit is a test. On its own, it fails. With the fix in the
second commit, the test passes.

Fixes #803

(Note: This is stacked on #804)

---------

Co-authored-by: Jimmi Dyson <[email protected]>

cmd/mindthegap/create/bundle/bundle.go

@@ -132,7 +132,7 @@ func NewCommand(out output.Output) *cobra.Command {
 				return fmt.Errorf("failed to create local Docker registry: %w", err)
 			}
 			go func() {
-				if err := reg.ListenAndServe(); err != nil {
+				if err := reg.ListenAndServe(output.NewOutputLogr(out)); err != nil {
 					out.Error(err, "error serving Docker registry")
 					os.Exit(2)
 				}

cmd/mindthegap/importcmd/imagebundle/image_bundle.go

@@ -83,7 +83,7 @@ func NewCommand(out output.Output) *cobra.Command {
 				return fmt.Errorf("failed to create local Docker registry: %w", err)
 			}
 			go func() {
-				if err := reg.ListenAndServe(); err != nil {
+				if err := reg.ListenAndServe(output.NewOutputLogr(out)); err != nil {
 					out.Error(err, "error serving Docker registry")
 					os.Exit(2)
 				}

cmd/mindthegap/push/bundle/bundle.go

@@ -111,7 +111,7 @@ func NewCommand(out output.Output, bundleCmdName string) *cobra.Command {
 				return fmt.Errorf("failed to create local Docker registry: %w", err)
 			}
 			go func() {
-				if err := reg.ListenAndServe(); err != nil {
+				if err := reg.ListenAndServe(output.NewOutputLogr(out)); err != nil {
 					out.Error(err, "error serving Docker registry")
 					os.Exit(2)
 				}

cmd/mindthegap/root/root.go

@@ -9,6 +9,7 @@ import (
 	"strings"
 
 	"github.com/spf13/cobra"
+	ctrllog "sigs.k8s.io/controller-runtime/pkg/log"
 
 	"github.com/mesosphere/dkp-cli-runtime/core/cmd/root"
 	"github.com/mesosphere/dkp-cli-runtime/core/output"
@@ -19,6 +20,12 @@ import (
 	"github.com/mesosphere/mindthegap/cmd/mindthegap/serve"
 )
 
+const (
+	// MinimumVerbosityForControllerRuntimeMessages is the minimum verbosity at which controller-runtime
+	// log messages are included in the output. Set to >= 1 to exclude from default output.
+	MinimumVerbosityForControllerRuntimeMessages = 1
+)
+
 func NewCommand(in io.Reader, out, errOut io.Writer) (*cobra.Command, output.Output) {
 	rootCmd, rootOpts := root.NewCommand(out, errOut)
 
@@ -53,6 +60,10 @@ func Execute() {
 	// disable cobra built-in error printing, we output the error with formatting.
 	rootCmd.SilenceErrors = true
 
+	// All packages in the controller-runtime module expect this logger to be
+	// defined within 30 seconds of initialization.
+	ctrllog.SetLogger(output.NewOutputLogr(out))
+
 	if err := rootCmd.Execute(); err != nil {
 		out.Error(err, "")
 		os.Exit(1)

cmd/mindthegap/serve/bundle/bundle.go

@@ -103,7 +103,7 @@ func NewCommand(
 			out.Infof("Listening on %s\n", reg.Address())
 
 			go func() {
-				if err := reg.ListenAndServe(); err != nil &&
+				if err := reg.ListenAndServe(output.NewOutputLogr(out)); err != nil &&
 					!errors.Is(err, http.ErrServerClosed) {
 					out.Error(err, "error serving Docker registry")
 					os.Exit(2)