feat: upgrade to go 1.23.4 #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The project failed to compile it looks like. Lets make sure CI is 🟢 before requesting reviews. I moved the PR back to draft meanwhile. Thanks! |
|
Hi @dkoshkin |
|
@ArvinderPal09 could you please bump the golangci-lint dependency, which will work correctly with go 1.23.4 - https://github.com/mesosphere/kubefed/blob/master/scripts/download-binaries.sh#L71 |
Sure I will check the compatible version of golangci-lint and bump it. |
ArvinderPal09
force-pushed
the
sandy/update-dependencies
branch
from
cbdb89d to
bedfa50
Compare
This reverts commit bfeeeb4.
ArvinderPal09
force-pushed
the
sandy/update-dependencies
branch
from
a2f36a2 to
865d8f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
update go version
Which issue(s) this PR fixes
https://jira.nutanix.com/browse/NCN-104688
Special notes for your reviewer: