-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update k8s debian package repositories to pkgs.k8s.io, bumps critools to 1.28 #996
Conversation
added a commit to use 1.28.6 so its consistent with #988 |
f8454c5
to
269c974
Compare
Thanks for this. I fixed the deb revision in the dkp-release repo, but not here. I'll want to backport this to release-2.5 |
Co-authored-by: Shalin Patel <[email protected]>
2f6415e
to
ca519c9
Compare
Thanks for the fixes @cwyl02! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its safe to ignore the nvidia kernel mismatch since the Ubuntu e2e passed
…tools to 1.28 (#996) * chore: Update k8s debian package repositories to pkgs.k8s.io --------- Co-authored-by: York Chen <[email protected]> Co-authored-by: Shalin Patel <[email protected] Signed-off-by: Daniel Lipovetsky <[email protected]>
--------- Co-authored-by: York Chen <[email protected]> Co-authored-by: Shalin Patel <[email protected] Signed-off-by: Daniel Lipovetsky <[email protected]>
--------- Co-authored-by: York Chen <[email protected]> Co-authored-by: Shalin Patel <[email protected] Signed-off-by: Daniel Lipovetsky <[email protected]>
--------- Co-authored-by: York Chen <[email protected]> Co-authored-by: Shalin Patel <[email protected] Signed-off-by: Daniel Lipovetsky <[email protected]>
) --------- Co-authored-by: Shalin Patel <[email protected] Signed-off-by: Daniel Lipovetsky <[email protected]> Co-authored-by: Kaiwalya R Joshi <[email protected]>
What problem does this PR solve?:
pkgs.k8s.io
Which issue(s) does this PR fix?:
Special notes for your reviewer:
kubernetes_version
via{{ kubernetes_major }}.{{ kubernetes_minor }}.{{ kubernetes_patch}}
but this fails many tests as the templated version is referenced by the Magefile here.Does this PR introduce a user-facing change?: