Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create package bundle for ubuntu 22.04 #1250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

supershal
Copy link
Collaborator

What problem does this PR solve?:

Which issue(s) does this PR fix?:

Special notes for your reviewer:

tested manually and GHA e2e tests will verify this.
ensure that both cloud-init packages are installed.

❯ tar -tvf 1.31.4_ubuntu_22.04_x86_64.tar.gz | grep cloud-init
-rw-r--r--  0 501    dialout  530940 Apr 25  2023 cloud-init_23.1.2-0ubuntu0~22.04.1_all.deb
-rw-r--r--  0 501    dialout  564688 Dec  5 03:13 cloud-init_24.4-0ubuntu1~22.04.1_all.deb
-rw-r--r--  0 501    dialout    4028 Aug 17  2020 cloud-initramfs-copymods_0.47ubuntu1_all.deb
-rw-r--r--  0 501    dialout    6540 Aug 17  2020 cloud-initramfs-dyn-netconf_0.47ubuntu1_all.deb

Does this PR introduce a user-facing change?:


@supershal supershal self-assigned this Jan 8, 2025
@supershal supershal added runs-vsphere-tests runs the vsphere e2e tests runs-aws-tests labels Jan 8, 2025
sed -i 's/cri-tools/cri-tools='"{{ .CRIToolsVersion }}-${CRI_TOOLS_DEB_BUILD_VERSION}"'/' /tmp/packages
# https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4745 pins version for CAPA
# enable it back if https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4745, https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/5115 are resolved
echo 'cloud-init=23.1.2-0ubuntu0~22.04.1' >> /tmp/packages
Copy link
Collaborator Author

@supershal supershal Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will add two cloud-init packages in the bundle. one latest and one with this specific version.
Since the package-bundle command is provider agnostic, I think it should be okay to have to version of a packages in bundle instead of adding provider specific logic.

If you are fine with this, I will make the same changes for ununtu-20.04 too in separate PR.
@dkoshkin @faiq

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can handle this another way and should probably move away from this sort of pinning altogether

@supershal supershal requested review from dkoshkin and faiq January 8, 2025 23:38
@supershal
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants