Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-2.9): remove using undefined flags in magefile #1199

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

supershal
Copy link
Collaborator

What problem does this PR solve?:
Incorrect Magefile changes were merged when cherry-picking #1133 to release-2.9 branch.
This PR removes use of the unused flags.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@supershal supershal self-assigned this Oct 9, 2024
@supershal supershal added the runs-e2e-tests runs e2e tests for GHA label Oct 9, 2024
@github-actions github-actions bot added the fix label Oct 9, 2024
@supershal supershal added runs-vsphere-tests runs the vsphere e2e tests and removed fix runs-e2e-tests runs e2e tests for GHA labels Oct 9, 2024
@supershal supershal requested a review from dlipovetsky October 9, 2024 18:14
@supershal
Copy link
Collaborator Author

The RHEL 7.9 and RHEL 8.4 are deprecated. Their mirrors does not have needed packages to build the VM.
We will ignore the e2e failures in RHEL 8.4 and RHEL 7.9 for releasing v2.9.9.
We need to backport #1072 later after v2.9.9 is released.

@supershal supershal requested a review from dkoshkin October 9, 2024 19:18
@supershal supershal added runs-e2e-tests runs e2e tests for GHA and removed runs-vsphere-tests runs the vsphere e2e tests labels Oct 9, 2024
@supershal supershal merged commit db9845b into release-2.9 Oct 9, 2024
55 of 85 checks passed
@supershal supershal deleted the shalin/cloud-init-vsphere branch October 9, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runs-e2e-tests runs e2e tests for GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants