Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.8] fix: cloud init problems with ubuntu (#1150) #1198

Conversation

dlipovetsky
Copy link
Collaborator

@dlipovetsky dlipovetsky commented Oct 9, 2024

What problem does this PR solve?:
Backport of #1150.

Similar to #1173, which was for release-2.5.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


* fix: cloud init problems with ubuntu (#1150)

* fix: install guest info if cloud init version is > 23.1.2

* ci: adds basic ubuntu test

* fix: adds handling for redhat system and cloud init

* !fixup: higher parallel

* fix: adds override for ubuntu tests

* do not merge: build basic os for ubuntu

* do not merge: ensure new cloud init for tests

* fix: remove package pining

* fix: remvove cloud-init dropin for custom vmware guest datasource

* fix: magefile configuration to create vsphere infa override file

---------

Co-authored-by: Shalin Patel <[email protected]>

* ci: run rocky basic e2e tests

---------

Co-authored-by: Faiq <[email protected]>
Signed-off-by: Daniel Lipovetsky <[email protected]>
@dlipovetsky dlipovetsky added the runs-vsphere-tests runs the vsphere e2e tests label Oct 9, 2024
@dlipovetsky dlipovetsky requested a review from supershal October 9, 2024 18:22
@dlipovetsky
Copy link
Collaborator Author

Only failing tests are AWS for RHEL 7.9 derivatives. Because these are EOL, we cannot access their packages, and cannot test them.

We need to investigate an ubuntu2004-nvidia failure. Once we resolve that, we can merge.

@dlipovetsky
Copy link
Collaborator Author

I'll merge this, and we'll investigate ubuntu2004-nvidia in a followup.

@dlipovetsky dlipovetsky merged commit 4be94f6 into release-2.8 Oct 9, 2024
22 checks passed
@dlipovetsky dlipovetsky deleted the dlipovetsky/backport-vmware-data-source-fix-release-2.8 branch October 9, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runs-vsphere-tests runs the vsphere e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants