Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove snapshot groups #1124

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: remove snapshot groups #1124

merged 1 commit into from
Jul 19, 2024

Conversation

faiq
Copy link
Collaborator

@faiq faiq commented Jul 19, 2024

What problem does this PR solve?:
Removes snapshot groups from being shared.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added the fix label Jul 19, 2024
@faiq faiq force-pushed the faiq/remove-snapshot-groups branch from 97cde0e to 9769093 Compare July 19, 2024 17:59
Copy link
Collaborator

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. we need to revisit all the defaults.

@faiq faiq merged commit 5598358 into main Jul 19, 2024
41 of 46 checks passed
@faiq faiq deleted the faiq/remove-snapshot-groups branch July 19, 2024 19:14
dlipovetsky pushed a commit that referenced this pull request Sep 24, 2024
dlipovetsky pushed a commit that referenced this pull request Sep 24, 2024
dlipovetsky pushed a commit that referenced this pull request Sep 24, 2024
dlipovetsky added a commit that referenced this pull request Sep 27, 2024
dlipovetsky added a commit that referenced this pull request Sep 27, 2024
dlipovetsky added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants