Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create new app for Gateway API #3057

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Create new app for Gateway API #3057

wants to merge 8 commits into from

Conversation

shubham2g
Copy link
Contributor

What problem does this PR solve?:
Add dedicated app for Gateway API CRDs

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105328

@shubham2g shubham2g self-assigned this Jan 24, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/traefik labels Jan 24, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 24, 2025
@coveralls
Copy link

coveralls commented Jan 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12984012590

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12945942450: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from ce76e34 to 89ec410 Compare January 24, 2025 11:35
@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from 7a49d06 to 8b68156 Compare January 24, 2025 11:50
@shubham2g shubham2g added ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Jan 24, 2025
@shubham2g shubham2g force-pushed the Shubham/Gateway-API-App branch from 40b56ea to 4085279 Compare January 24, 2025 12:12
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2025
@github-actions github-actions bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
mhrabovcin
mhrabovcin reviewed Jan 27, 2025
View reviewed changes
services/traefik/34.1.0/crds.yaml
Comment on lines +7 to +10
dependsOn:
# There can only be one operator per cluster, just ensure CRDs are present, no need to wait for actual operator Deployment.
- name: traefik-crd-prereq-jobs-v34.1.0
namespace: ${workspaceNamespace}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Kustomization is installing the CRD, so there is no need to add dependsOn. However the traefik HR installation should be moved to a separate kustomization and should wait

mhrabovcin
mhrabovcin reviewed Jan 27, 2025
View reviewed changes
services/traefik/34.1.0/kustomization.yaml
@@ -3,3 +3,5 @@ kind: Kustomization
resources:
- traefik.yaml
- grafana-dashboards
- crds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- crds

This will get included by the kustomization in crds.yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@shubham2g shubham2g

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/traefik size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shubham2g @coveralls @mhrabovcin @mesosphere-ci @d2iq-mergebot