Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump to docker.io/rook/ceph:v1.16.2 #3040

Merged
merged 7 commits into from
Jan 24, 2025
Merged

feat: bump to docker.io/rook/ceph:v1.16.2 #3040

merged 7 commits into from
Jan 24, 2025

Conversation

Venkat-Bramhasani
Copy link
Contributor

What problem does this PR solve?:
feat: bump to docker.io/rook/ceph:v1.16.2

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-105207

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2025
@coveralls
Copy link

coveralls commented Jan 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12953540259

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12953499192: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/venkat/featbump-to-docker.io/rook/cephv1.16.1

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
@Venkat-Bramhasani Venkat-Bramhasani self-assigned this Jan 20, 2025
@Venkat-Bramhasani Venkat-Bramhasani added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/venkat/featbump-to-docker.io/rook/cephv1.16.1

@Venkat-Bramhasani
Copy link
Contributor Author

Hi @mhrabovcin , can you please have a look into it and approve it.

takirala
takirala reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@takirala takirala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rook-ceph and rook-ceph-cluster needs to be bumped together. Please open a PR in kommander repo and run thru the CI checks once you bump both the apps.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/rook-ceph-cluster and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@Venkat-Bramhasani Venkat-Bramhasani added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/venkat/featbump-to-docker.io/rook/cephv1.16.1

@Venkat-Bramhasani
Copy link
Contributor Author

Hi @takirala , as you suggested i have made changes to rook-ceph-cluster as well, can you please verify.

takirala
takirala reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@takirala takirala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you bumping to v1.16.0 or 1.16.2 ? Lets bump to same version across all components. Kommander repo tests needs to be updated as well https://github.com/mesosphere/kommander/pull/5300/files (you can reuse https://github.com/mesosphere/kommander/pull/5460)

@Venkat-Bramhasani Venkat-Bramhasani force-pushed the venkat/featbump-to-docker.io/rook/cephv1.16.1 branch from 5c0de00 to 31d6da2 Compare January 22, 2025 04:22
@Venkat-Bramhasani
Copy link
Contributor Author

Hi @takirala , I’m bumping the Rook/Ceph version to v1.16.2. As per your suggestion, I’ve made the necessary changes. Could you please verify and approve them.

@Venkat-Bramhasani Venkat-Bramhasani force-pushed the venkat/featbump-to-docker.io/rook/cephv1.16.1 branch from 31d6da2 to 57e2b88 Compare January 23, 2025 07:28
@SandhyaRavi2403 SandhyaRavi2403 mentioned this pull request Jan 23, 2025
Closed
@Venkat-Bramhasani
Copy link
Contributor Author

Hi @takirala @mhrabovcin, could you please review this PR and let me know if any changes are needed for approval. Thanks!

@Venkat-Bramhasani Venkat-Bramhasani enabled auto-merge (squash) January 24, 2025 06:15
@Venkat-Bramhasani Venkat-Bramhasani force-pushed the venkat/featbump-to-docker.io/rook/cephv1.16.1 branch from 3a961fb to 840f02d Compare January 24, 2025 12:07
@Venkat-Bramhasani
Copy link
Contributor Author

Hi @mhrabovcin @takirala , can you please merge this PR.

@takirala takirala enabled auto-merge (squash) January 24, 2025 16:27
@takirala takirala merged commit d28dd0b into main Jan 24, 2025
26 checks passed
@takirala takirala deleted the venkat/featbump-to-docker.io/rook/cephv1.16.1 branch January 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala takirala approved these changes

@mhrabovcin mhrabovcin Awaiting requested review from mhrabovcin

Assignees

@Venkat-Bramhasani Venkat-Bramhasani

Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/rook-ceph services/rook-ceph-cluster size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Venkat-Bramhasani @coveralls @mhrabovcin @takirala @mesosphere-ci