-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update CA trust bundle for kubecost containers #3004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Gupta Akirala <[email protected]>
github-actions
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
services/rook-ceph-cluster
services/traefik
services/kubecost
services/velero
labels
Jan 10, 2025
mesosphere-ci
added
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
do-not-merge/testing
Do not merge because there is still on-going testing
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
update-licenses
signals mergebot to update licenses.d2iq.yaml
labels
Jan 10, 2025
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/kubecost-use-custom-ca |
Pull Request Test Coverage Report for Build 12754563307Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
takirala
changed the title
feat: use custom CA in cosi
feat: update CA trust bundle for kubecost containers
Jan 10, 2025
takirala
removed
the
do-not-merge/testing
Do not merge because there is still on-going testing
label
Jan 10, 2025
mhrabovcin
approved these changes
Jan 13, 2025
mhrabovcin
reviewed
Jan 13, 2025
services/rook-ceph-cluster/1.15.5/objectbucketclaims/helmrelease.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Tarun Gupta Akirala <[email protected]>
mesosphere-ci
added
the
do-not-merge/testing
Do not merge because there is still on-going testing
label
Jan 13, 2025
Signed-off-by: Tarun Gupta Akirala <[email protected]>
cwyl02
requested changes
Jan 13, 2025
cwyl02
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge/testing
Do not merge because there is still on-going testing
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
services/kubecost
services/rook-ceph-cluster
services/traefik
services/velero
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
update-licenses
signals mergebot to update licenses.d2iq.yaml
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
update-ca-trust
init container from the latest chart. This enables the attached cluster's Kubecost to communicate with the management cluster's COSI bucket using a custom CA.velero-ceph
entrypoint toexternal-ceph
. This is purely a metadata change and does not affect functionality (e.g., ports remain unchanged).velero-ceph
ingress definition from the Velero app to the Ceph app. This ensures the ingress is deployed whenever Ceph is deployed, aligning with its use by both the Velero CLI and Kubecost agents. Deploying it from the Ceph app avoids redundancy and simplifies management. Additionally, since the rename changes the ingress name, upgrades will not encounter naming conflicts.Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-104938
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist