Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: git operator cronjob use same kubectl #3000

Merged
merged 7 commits into from
Jan 9, 2025
Merged

fix: git operator cronjob use same kubectl #3000

merged 7 commits into from
Jan 9, 2025

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Jan 9, 2025

What problem does this PR solve?:
git operator cronjob is using an older version of kubectl

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105003

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cwyl02 cwyl02 requested a review from a team January 9, 2025 16:14
@cwyl02 cwyl02 self-assigned this Jan 9, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@cwyl02 cwyl02 added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off auto-backport backport-to-main labels Jan 9, 2025
@cwyl02 cwyl02 force-pushed the ychen/git-operator-cronjob-use-same-kubectl branch from d23a9fa to 43e177a Compare January 9, 2025 17:17
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@cwyl02 cwyl02 force-pushed the ychen/git-operator-cronjob-use-same-kubectl branch from d0aab56 to e76b7cc Compare January 9, 2025 18:30
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@cwyl02 cwyl02 force-pushed the ychen/git-operator-cronjob-use-same-kubectl branch from 3aaa0e1 to 0b42b51 Compare January 9, 2025 19:33
@cwyl02 cwyl02 merged commit 60ba482 into release-2.13 Jan 9, 2025
17 of 18 checks passed
@cwyl02 cwyl02 deleted the ychen/git-operator-cronjob-use-same-kubectl branch January 9, 2025 20:03
mesosphere-ci pushed a commit that referenced this pull request Jan 9, 2025
@cwyl02
fix: git operator cronjob use same kubectl (#3000)
fb1909a 
* fix: use the same kubectl for gitoperator cronjob

* chore: patch the cronjob image from kustomization

* refactor: use kustomization to swap image

* refactor: use patch to replace img

* chore: add kubectl 1296 back to license yaml

* refactor: use extra-images for git-operator

* refactor: fix list images for git operator

(cherry picked from commit 60ba482)
@mesosphere-ci
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ main

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mesosphere-ci mesosphere-ci mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala takirala approved these changes

Assignees

@cwyl02 cwyl02

Labels
auto-backport backport-to-main ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwyl02 @mesosphere-ci @takirala