Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove v from app version, bump API version of HR #2990

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

mikolajb
Copy link
Contributor

@mikolajb mikolajb commented Jan 6, 2025

What problem does this PR solve?:
It seems that by convention - we don't use v in version.

E2e failure that is related to this: https://github.com/mesosphere/kommander-e2e/actions/runs/12627430119/job/35182211251#step:16:3648

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mikolajb mikolajb self-assigned this Jan 6, 2025
@mikolajb mikolajb requested a review from a team January 6, 2025 16:48
@github-actions github-actions bot added services/nkp-pulse-management services/nkp-pulse-workspace size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@mikolajb mikolajb requested review from takirala and cwyl02 January 6, 2025 16:50
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12636721759

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 12608768288: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Copy link
Contributor

@takirala takirala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yours but do you mind bumping the hr version in https://github.com/mesosphere/kommander-applications/blob/mikolajb/remove-v/services/nkp-pulse-management/0.0.1-dev.0/helmrelease.yaml#L1 nkp-pulse-management app from v2beta1 to v2beta2

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@mikolajb mikolajb changed the title chore: Remove v from app version chore: Remove v from app version, bump API version of HR Jan 6, 2025
@mikolajb mikolajb requested a review from kaiwalyajoshi January 6, 2025 16:56
@mikolajb mikolajb merged commit 3a741fd into main Jan 6, 2025
28 checks passed
@mikolajb mikolajb deleted the mikolajb/remove-v branch January 6, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/nkp-pulse-management services/nkp-pulse-workspace size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants