-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to kubecost v2 #2959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
services/centralized-kubecost
services/kubecost
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Dec 18, 2024
mesosphere-ci
added
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
do-not-merge/testing
Do not merge because there is still on-going testing
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
update-licenses
signals mergebot to update licenses.d2iq.yaml
labels
Dec 18, 2024
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/kubecost-v2 |
Pull Request Test Coverage Report for Build 12661230226Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
takirala
force-pushed
the
tga/kubecost-v2
branch
from
December 22, 2024 02:46
cb540e7
to
adfdd5e
Compare
takirala
removed
do-not-merge/testing
Do not merge because there is still on-going testing
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
labels
Dec 26, 2024
takirala
force-pushed
the
tga/kubecost-v2
branch
from
December 31, 2024 01:20
74d13cd
to
af958f9
Compare
mesosphere-ci
added
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
do-not-merge/testing
Do not merge because there is still on-going testing
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
labels
Dec 31, 2024
takirala
removed
the
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
label
Dec 31, 2024
takirala
force-pushed
the
tga/kubecost-v2
branch
from
January 3, 2025 00:27
0253a65
to
e8d2381
Compare
mesosphere-ci
added
the
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
label
Jan 3, 2025
takirala
force-pushed
the
tga/kubecost-v2
branch
from
January 3, 2025 00:31
8df7a3c
to
05d12e5
Compare
mhrabovcin
reviewed
Jan 3, 2025
mhrabovcin
reviewed
Jan 3, 2025
services/centralized-kubecost/2.5.0/cosi-storage/cosi-bucket.yaml
Outdated
Show resolved
Hide resolved
takirala
force-pushed
the
tga/kubecost-v2
branch
3 times, most recently
from
January 3, 2025 18:36
ad27542
to
f839bb7
Compare
takirala
force-pushed
the
tga/kubecost-v2
branch
from
January 4, 2025 08:15
235d816
to
e793a3b
Compare
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
takirala
force-pushed
the
tga/kubecost-v2
branch
from
January 6, 2025 23:26
d155144
to
26e7210
Compare
takirala
removed
the
do-not-merge/testing
Do not merge because there is still on-going testing
label
Jan 6, 2025
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
mesosphere-ci
added
the
do-not-merge/testing
Do not merge because there is still on-going testing
label
Jan 7, 2025
mhrabovcin
reviewed
Jan 7, 2025
mhrabovcin
reviewed
Jan 7, 2025
mhrabovcin
approved these changes
Jan 7, 2025
Signed-off-by: Tarun Gupta Akirala <[email protected]>
cwyl02
approved these changes
Jan 7, 2025
Signed-off-by: Tarun Gupta Akirala <[email protected]>
Signed-off-by: Tarun Gupta Akirala <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge/testing
Do not merge because there is still on-going testing
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
ready-for-review
services/centralized-grafana
services/centralized-kubecost
services/kommander
services/kommander-ui
services/kubecost
services/nkp-insights
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
update-licenses
signals mergebot to update licenses.d2iq.yaml
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Upgrade kubecost to v2.
From 2.14.x, we no longer need centralized-kubecost as there is no need to run multiple instance of kubecost on management cluster. We will have just one
kubecost
service which is controlled via thevaluesFrom
field of kubecostHelmRelease
. I have added comments where needed and there are some TODO's left in the code that will be follow up PRs.Which issue(s) does this PR fix?:
NCN-104266
NCN-104267
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist