Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use explicit name when publishing s3 blobs #2740

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

takirala
Copy link
Contributor

What problem does this PR solve?:

Follow up of #2710

Above change corrupted how we publish artifacts cuz i see:

 ❯ curl -L https://downloads.d2iq.com/dkp/v2.13.0-dev.2 --output local.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  449k  100  449k    0     0  1414k      0 --:--:-- --:--:-- --:--:-- 1413k
 ❯ tar -tvf local.tar.gz
drwxr-xr-x runner/runner     0 2024-10-14 18:30 ./
drwxr-xr-x runner/runner     0 2024-10-14 18:29 ./charts/
drwxr-xr-x runner/runner     0 2024-10-14 18:29 ./charts/kommander-operator/
-rw-r--r-- runner/runner   168 2024-10-14 18:29 ./charts/kommander-operator/Chart.yaml

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11353848515

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 11353130009: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@takirala takirala marked this pull request as ready for review October 15, 2024 20:33
@takirala takirala self-assigned this Oct 15, 2024
@takirala takirala requested review from gracedo and cwyl02 October 15, 2024 20:33
Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can test it by tagging this as v2.13.0-dev

@takirala takirala merged commit d15fab3 into main Oct 15, 2024
18 checks passed
@takirala takirala deleted the tga/fix-tooling branch October 15, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants