Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "feat: Bump rook-ceph to v1.12.3" #1699

Merged
merged 1 commit into from
Oct 26, 2023
Merged

revert: "feat: Bump rook-ceph to v1.12.3" #1699

merged 1 commit into from
Oct 26, 2023

Conversation

mikolajb
Copy link
Contributor

@mikolajb mikolajb added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Oct 26, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/rook-ceph-cluster services/rook-ceph labels Oct 26, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Oct 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6653498133

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%
Totals Coverage Status
Change from base Build 6651574524: 0.0%
Covered Lines: 136
Relevant Lines: 171
💛 - Coveralls

@mikolajb mikolajb requested a review from a team October 26, 2023 10:18
@mikolajb mikolajb self-assigned this Oct 26, 2023
@takirala
Copy link
Contributor

i am not against the revert but i am skeptical if it would help. See https://d2iq.atlassian.net/browse/D2IQ-99609?focusedCommentId=566655

@takirala
Copy link
Contributor

I ll merge and tag v2.7.0-dev to see if this allows the CI to 🟢

@takirala takirala merged commit 96aa9d6 into main Oct 26, 2023
29 checks passed
@takirala takirala deleted the revert-1521-chartbump/rook-ceph-v1.12.3 branch October 26, 2023 20:34
@takirala takirala mentioned this pull request Oct 26, 2023
Merged
2 tasks
@takirala
Copy link
Contributor

This didnt help CI as its still failing with same errors https://github.com/mesosphere/kommander-e2e/actions/runs/6659602472/job/18099035204#step:15:3448

Bumping ceph to latest via #1700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonofgibs sonofgibs sonofgibs approved these changes

@takirala takirala takirala approved these changes

Assignees

@mikolajb mikolajb

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/rook-ceph services/rook-ceph-cluster size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikolajb @d2iq-mergebot @coveralls @takirala @sonofgibs