Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Double memory resources for prometheus-adapter #1691

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: Double memory resources for prometheus-adapter #1691

merged 1 commit into from
Oct 23, 2023

Conversation

mikolajb
Copy link
Contributor

What problem does this PR solve?:
Doubling resources for prometheus adapter as discussed here:
https://d2iq.slack.com/archives/CJZQDQMSR/p1696956332307929?thread_ts=1696954502.650439&cid=CJZQDQMSR

Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-99404

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mikolajb mikolajb self-assigned this Oct 23, 2023
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/prometheus-adapter labels Oct 23, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@mikolajb mikolajb added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Oct 23, 2023
@mikolajb mikolajb requested a review from a team October 23, 2023 10:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6611940509

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%
Totals Coverage Status
Change from base Build 6591473337: 0.0%
Covered Lines: 136
Relevant Lines: 171
💛 - Coveralls

@mikolajb mikolajb enabled auto-merge (squash) October 23, 2023 10:54
@mikolajb mikolajb merged commit ec8b2f9 into main Oct 23, 2023
26 checks passed
@mikolajb mikolajb deleted the mikolajb/prometheus-adapter-memory-fix branch October 23, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palexster palexster palexster approved these changes

@tillt tillt tillt approved these changes

Assignees

@mikolajb mikolajb

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/prometheus-adapter size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikolajb @d2iq-mergebot @coveralls @tillt @palexster