🐛 fix: considers objects in kube-system for cert-manager to avoid upgrading twice #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiq
force-pushed
the
faiq/fix-clusterctl-cert-manager
branch
from
ded6366 to
6d2359d
Compare
supershal
reviewed
Oct 29, 2024
faiq
force-pushed
the
faiq/fix-clusterctl-cert-manager
branch
from
6d2359d to
a3c4987
Compare
dkoshkin
approved these changes
Oct 31, 2024
faiq
force-pushed
the
faiq/fix-clusterctl-cert-manager
branch
from
a3c4987 to
cf94a10
Compare
faiq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Downstream of kubernetes-sigs#11351
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #