Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(knative): add missing domainmappings v1alpha1 version #1528

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix(knative): add missing domainmappings v1alpha1 version #1528

merged 3 commits into from
Nov 25, 2024

Conversation

mhrabovcin
Copy link
Contributor

What type of PR is this?

Bug

What this PR does/ why we need it:

  • Flux cannot upgrade between 1.10.4 and latest version because of the missing v1alpha1 version for domainmappings resources.
  • It is necessary to disable more webhooks to get error free upgrades

Which issue(s) this PR fixes:

https://jira.nutanix.com/browse/NCN-104372

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@mhrabovcin mhrabovcin requested a review from takirala November 25, 2024 19:55
@mhrabovcin mhrabovcin self-assigned this Nov 25, 2024
@mhrabovcin mhrabovcin requested review from a team as code owners November 25, 2024 19:55
@takirala takirala merged commit 5e8d404 into master Nov 25, 2024
5 checks passed
@takirala takirala deleted the mh/knative-domainmappings branch November 25, 2024 20:48
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
fix(knative): add missing domainmappings v1alpha1 version (#1528) * f…
5867207 
…ix(knative): add missing domainmappings v1alpha1 version * fix(knative): disable mutating webhooks * chore(knative): bump chart version to 1.15.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala takirala approved these changes

Assignees

@mhrabovcin mhrabovcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhrabovcin @takirala