Fix picojson header file issue #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzhiwei
force-pushed
the
fix-picojson
branch
from
90727e9
to
6cd94e9
Compare
| @@ -0,0 +1 @@ | |||
| Subproject commit cc130fbcb165ffbc2aa7a7fadfe98ff6ed4120c8 | |||
There was a problem hiding this comment.
Instead of using the head of PicoJson, you should instead point to PicoJson 1.3.0:
25fc213cca61ea22b3c2e4db8def9927562ba5f7
(We recently updated this dependency).
Use the built-in picojson git submodule instead of system-wide picojson
chenzhiwei
force-pushed
the
fix-picojson
branch
from
6cd94e9
to
26ff9f6
Compare
|
@kaysoky Thanks, uploaded a new patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the built-in picojson git submodule instead of system-wide picojson