Code Hygiene Job + Misc clippy fixes. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lukipuki
approved these changes
May 22, 2024
|
Looks good! I'm struggling to push the merge conflict fix, it's just keeping both |
|
I have been swamped since I added this back in May. Will take a look at what's going on with the latest conflicts, and will try to get it back into shape on |
canardleteer
force-pushed
the
dev/canardleteer/code-cleanup
branch
from
e502864
to
e70b1b0
Compare
|
Rebased, and now passing new tests. Didn't bother checking to see if it was |
lukipuki
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was pulling in the project locally, and noticed some lints failing. Trued those up in a way that I figured was reasonable, added a code hygiene job and refreshed the Actions a bit to reduce the warnings.