-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Detection Sensor Module) Send message to channel/node not public #615
Conversation
sendTo changed to uint32_t, some text changed to reflect changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed as requested
These changes are pretty unlikely to make it into the client apps, would be the only module directing traffic like this. |
It's a big change in how this module works, so I hope it will make it into client apps. |
As designed here, cli only is the likely outcome. Channels and node nums can be easily deleted, need to work with the existing apps as is. |
If we can't add features to it then the only option left is to lock it as meshtastic do with GPIO hardware. I really do like that I can choose what channel or if it should be a DM, if we lock it to a channel that would be limiting users with one less slot for channels. If we don't do anything, some will be annoyed with all of the messages the module is sending on public preset channel |
It should be blocked on the default channel key, but using another channel in the same slot is no better for the mesh. |
It's not blocked. |
Yeah that should be added, but the choosing a channel or dm node is not something the clients can currently manage. |
Theses change are a part of preventing spamming messages from Detection Sensor Module on Public channel.
PR coming to Meshtastic firmware as well.
sendTo - Can be a Channel name or NodeID
sendTochannel - If true, messages will be redirected to channel but blocked if it's Public.