convert hops_away from required to optional #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersjcb
changed the title
|
confirmed with passing PR build https://github.com/powersjcb/protobufs/actions/runs/10895520695/job/30233893217 |
|
this change has been tested and deployed with a rak4631 based on this firmware version. |
|
Requesting review from @thebentern Nodeinfo (lite) is quite expensive on the device and for even adding one byte i wanna make sure it's really really useful to pay that price. |
thebentern
approved these changes
Sep 17, 2024
|
Seems fair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
convert hops_away from required to optional
This will enable feature work to differentiate between hops_away not available and hops_away is zero
Checklist before merging