Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route back and SNR lists to RouteDiscovery for traceroute #563

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Aug 17, 2024

In order to get two-way information with SNR per hop in a traceroute, this adds another list of nodenums route_back and two lists of 1-byte SNR values (in dB, but scaled by 4, so e.g. a value of -64 is -16dB), namely snr_towards and snr_back.

This should allow us to visualize a traceroute from node 0x10 to 0x13 as:

0x10 --> 0x11 (-5.00dB) --> 0x12 (-4.00dB) --> 0x13 (7.00dB)
(-5.00dB) 0x10 <-- (-4.00dB) 0x11 <-- (7.00dB) 0x12 <-- 0x13

Copy link
Contributor

@thebentern thebentern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so this should be backward compatible. Perhaps in 3.0, we can make it a repeated of structured messages rather than separate arrays, but this is a good way to ensure that things still work with older firmware versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants