Fix issue #5193: Optimise GPS probe code - one message per family #5244
Conversation
|
|
|
Thanks for this! Taking a look :) |
|
Two things you can do while waiting for review:
|
There was a problem hiding this comment.
Thanks for this. A great beginning.
Further changes are needed. At the moment this checks whether we got a response to the command, which is a good start.
However, we actually care about the contents. Since the response to the command could be OK, but might correspond to a model number we don't support.
For example, we send the command $PCAS06,11A to look for ATGM336H or ATGM332D. When we see a response of $GPTXT,01,01,02,HW=ATGM336H we know the chip we have is an ATGM336H. If we see a response of $GPTXT,01,01,02,HW=ATGM332D we know it's an ATGM332D. However, we could also see $GNTXT,01,01,01,PCAS inv format23. where it's an invalid command for the chip connected , or it could be $GPTXT,01,01,02,HW=ATGM330B , which we don't support.
So the code should be extended to make the buffer from the first time we run the command available, so we can search it next time.
|
Hi @absolut3ego , did you need any help or pointers with this? I have a lot of GPS to test with, so if you want to make the code so can test it for you :) |
fifieldt
force-pushed
the
fix-issue-#5193
branch
from
2b3065b
to
a7946b5
Compare
| if (getACK(RESPONSE, TIMEOUT) == GNSS_RESPONSE_OK) { \ | ||
| LOG_INFO(DETECTED_MESSAGE, CHIP, #DRIVER); \ | ||
| return DRIVER; \ | ||
| #define PROBE_SIMPLE(CHIP, TOWRITE, RESPONSE, DRIVER, TIMEOUT, ...) \ |
There was a problem hiding this comment.
Why don't you implement this as a (lambda-) function? This macro code is copied 10 times into the source and consumes unnecessarily additional space.
I have upgraded the PROBE_SIMPLE macro. So that it can not need to do everything again when calling the same message. I simply added some variables to save the last command and based on it to execute the next commands, if it matches the latest command I do not need to do the steps in the PROBE_SIMPLE macro again but instead I will get the result and return it.