feat: Add PoolCreated event #109

quangkeu95 · 2024-01-04T03:06:00Z

Attempt to add PoolCreated event into the SDK IDL types

Tasks:

Add PoolCreated event type.
Add test and example how to subscribe to events from a program.

ts-client/src/amm/tests/pool.test.ts

00xSam · 2024-01-17T03:35:27Z

ts-client/src/amm/index.ts

@@ -63,7 +63,7 @@ type Opt = {
 };

 const getAllPoolState = async (poolMints: Array<PublicKey>, program: AmmProgram) => {
-  const poolStates = (await chunkedFetchMultiplePoolAccount(program, poolMints)) as Array<PoolState>;


why do we need to convert to any first?

seems like an outdated thing i added to bypass typescript compile error. It's not happened again then i'm gonna remove it.

00xSam · 2024-01-17T03:41:17Z

running pnpm run generate throw me error. Did you forgot to commit something?

00xSam · 2024-01-17T03:42:53Z

pnpm run anchor-test failed as well for me.

error: failed to run custom build command for `blake3 v1.5.0`

Caused by:
  process didn't exit successfully: `/Users/mcsam/Development/mercurial-dynamic-amm-sdk/target/release/build/blake3-18f03ff94989d032/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=CARGO_FEATURE_PURE
  cargo:rerun-if-env-changed=CARGO_FEATURE_NO_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_NO_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_PURE
  cargo:rustc-cfg=blake3_neon
  TARGET = Some("aarch64-apple-darwin")
  OPT_LEVEL = Some("0")
  HOST = Some("aarch64-apple-darwin")
  cargo:rerun-if-env-changed=CC_aarch64-apple-darwin
  CC_aarch64-apple-darwin = None
  cargo:rerun-if-env-changed=CC_aarch64_apple_darwin
  CC_aarch64_apple_darwin = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = Some("/Users/mcsam/.local/share/solana/install/releases/1.16.1/solana-release/bin/sdk/sbf/dependencies/platform-tools/llvm/bin/clang")
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  cargo:rerun-if-env-changed=CFLAGS_aarch64-apple-darwin
  CFLAGS_aarch64-apple-darwin = None
  cargo:rerun-if-env-changed=CFLAGS_aarch64_apple_darwin
  CFLAGS_aarch64_apple_darwin = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  running: "/Users/mcsam/.local/share/solana/install/releases/1.16.1/solana-release/bin/sdk/sbf/dependencies/platform-tools/llvm/bin/clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-darwin" "-Wall" "-Wextra" "-std=c11" "-o" "/Users/mcsam/Development/mercurial-dynamic-amm-sdk/target/release/build/blake3-5478e16ff4b3f7e8/out/c/blake3_neon.o" "-c" "c/blake3_neon.c"
  cargo:warning=In file included from c/blake3_neon.c:1:

  cargo:warning=c/blake3_impl.h:4:10: fatal error: 'assert.h' file not found

  cargo:warning=#include <assert.h>

  cargo:warning=         ^~~~~~~~~~

  cargo:warning=1 error generated.

  exit status: 1

  --- stderr


  error occurred: Command "/Users/mcsam/.local/share/solana/install/releases/1.16.1/solana-release/bin/sdk/sbf/dependencies/platform-tools/llvm/bin/clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-darwin" "-Wall" "-Wextra" "-std=c11" "-o" "/Users/mcsam/Development/mercurial-dynamic-amm-sdk/target/release/build/blake3-5478e16ff4b3f7e8/out/c/blake3_neon.o" "-c" "c/blake3_neon.c" with args "clang" did not execute successfully (status code exit status: 1).


warning: build failed, waiting for other jobs to finish...
 ELIFECYCLE  Command failed with exit code 1.
 ```

quangkeu95 · 2024-01-17T04:51:57Z

running `pnpm run generate` throw me error. Did you forgot to commit something?

I think we don't need to use the generated types so i'm gonna remove this command with the achor-client-gen dependency.

quangkeu95 · 2024-01-18T02:45:44Z

pnpm run anchor-test failed as well for me.

error: failed to run custom build command for `blake3 v1.5.0`

Caused by:
  process didn't exit successfully: `/Users/mcsam/Development/mercurial-dynamic-amm-sdk/target/release/build/blake3-18f03ff94989d032/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=CARGO_FEATURE_PURE
  cargo:rerun-if-env-changed=CARGO_FEATURE_NO_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_NO_NEON
  cargo:rerun-if-env-changed=CARGO_FEATURE_PURE
  cargo:rustc-cfg=blake3_neon
  TARGET = Some("aarch64-apple-darwin")
  OPT_LEVEL = Some("0")
  HOST = Some("aarch64-apple-darwin")
  cargo:rerun-if-env-changed=CC_aarch64-apple-darwin
  CC_aarch64-apple-darwin = None
  cargo:rerun-if-env-changed=CC_aarch64_apple_darwin
  CC_aarch64_apple_darwin = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = Some("/Users/mcsam/.local/share/solana/install/releases/1.16.1/solana-release/bin/sdk/sbf/dependencies/platform-tools/llvm/bin/clang")
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  cargo:rerun-if-env-changed=CFLAGS_aarch64-apple-darwin
  CFLAGS_aarch64-apple-darwin = None
  cargo:rerun-if-env-changed=CFLAGS_aarch64_apple_darwin
  CFLAGS_aarch64_apple_darwin = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  running: "/Users/mcsam/.local/share/solana/install/releases/1.16.1/solana-release/bin/sdk/sbf/dependencies/platform-tools/llvm/bin/clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-darwin" "-Wall" "-Wextra" "-std=c11" "-o" "/Users/mcsam/Development/mercurial-dynamic-amm-sdk/target/release/build/blake3-5478e16ff4b3f7e8/out/c/blake3_neon.o" "-c" "c/blake3_neon.c"
  cargo:warning=In file included from c/blake3_neon.c:1:

  cargo:warning=c/blake3_impl.h:4:10: fatal error: 'assert.h' file not found

  cargo:warning=#include <assert.h>

  cargo:warning=         ^~~~~~~~~~

  cargo:warning=1 error generated.

  exit status: 1

  --- stderr


  error occurred: Command "/Users/mcsam/.local/share/solana/install/releases/1.16.1/solana-release/bin/sdk/sbf/dependencies/platform-tools/llvm/bin/clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-darwin" "-Wall" "-Wextra" "-std=c11" "-o" "/Users/mcsam/Development/mercurial-dynamic-amm-sdk/target/release/build/blake3-5478e16ff4b3f7e8/out/c/blake3_neon.o" "-c" "c/blake3_neon.c" with args "clang" did not execute successfully (status code exit status: 1).


warning: build failed, waiting for other jobs to finish...
 ELIFECYCLE  Command failed with exit code 1.
 ```

would you mind running cargo clean and rerun the command, make sure you run in inside the ts-client dir. I'm not sure about this error.

andrewsource147 reviewed Jan 9, 2024

View reviewed changes

ts-client/src/amm/tests/pool.test.ts Outdated Show resolved Hide resolved

quangkeu95 force-pushed the feat/pool-created-event branch from 3de5ba7 to 75b4066 Compare January 10, 2024 08:11

quangkeu95 changed the base branch from master to staging January 10, 2024 08:26

quangkeu95 force-pushed the feat/pool-created-event branch from bc7cfa7 to 15ef218 Compare January 12, 2024 13:53

quangkeu95 added 26 commits January 15, 2024 14:27

feat: Add PoolCreated event

2b6b42d

fix: Remove fields from PoolCreated event

06010b8

fix: Bump anchor dependencies

17699b7

chore: Add new updated idl.json

be95855

fix: Seperate the types into files

caf727e

fix: Update import path for anchor

bba87ee

fix: Update localnet wallet path

cb35e5a

wip: Add event test for PoolCreated event

6ef83fd

fix: Update test setup for event test

b4a9157

fix: Using simulate method call

f6d16a2

fix: Update test to use anchor test

b259a47

chore: Format code

2fa60b7

fix: Update the IDL for new field in PoolCreated event

429821d

chore: Add subscribe pool account change test

ddb26dc

chore(format): Run pnpm fmt to format all the code

2f5d7d1

feat: Update test for pool reserve tracking

cdf2681

fix: Handle after reserve change triggered

e2f515e

fix: Rebase main

8e9ba8e

chore: Update staging AMM idl

d0cf8c6

fix: Update anchor localnet specific tests

9d74448

fix: Update IDL from amm staging

246c500

fix: Satisfy cargo check

416557f

fix: Fix cargo test

a5e9436

fix: Format cargo check

aa4e1df

chore: Add generated types

d16b95a

fix: Update PoolCreated event index

d351ada

quangkeu95 force-pushed the feat/pool-created-event branch from 15ef218 to d351ada Compare January 15, 2024 07:40

quangkeu95 added 3 commits January 15, 2024 15:19

fix: Revert anchor and borsh dependencies version

55e697e

chore: Update pool test

0852783

chore: Clone metaplex program

48e1d69

00xSam reviewed Jan 17, 2024

View reviewed changes

quangkeu95 added 2 commits January 17, 2024 11:52

fix: Remove generated files

cc895f0

fix: Remove redundant

df64fe2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add PoolCreated event #109

feat: Add PoolCreated event #109

quangkeu95 commented Jan 4, 2024 •

edited

Loading

00xSam Jan 17, 2024

quangkeu95 Jan 17, 2024

00xSam commented Jan 17, 2024

00xSam commented Jan 17, 2024

quangkeu95 commented Jan 17, 2024

quangkeu95 commented Jan 18, 2024

feat: Add PoolCreated event #109

Are you sure you want to change the base?

feat: Add PoolCreated event #109

Conversation

quangkeu95 commented Jan 4, 2024 • edited Loading

00xSam Jan 17, 2024

Choose a reason for hiding this comment

quangkeu95 Jan 17, 2024

Choose a reason for hiding this comment

00xSam commented Jan 17, 2024

00xSam commented Jan 17, 2024

quangkeu95 commented Jan 17, 2024

quangkeu95 commented Jan 18, 2024

quangkeu95 commented Jan 4, 2024 •

edited

Loading