Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strconv CEL library #244 #247

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Support strconv CEL library #244 #247

merged 7 commits into from
Oct 4, 2024

Conversation

pikachu0310
Copy link
Collaborator

@pikachu0310 pikachu0310 commented Sep 27, 2024

I have migrated Go's Strconv package to CEL. The functions are now consolidated within grpc.federation.strings.

This comment has been minimized.

This comment has been minimized.

@pikachu0310 pikachu0310 self-assigned this Sep 30, 2024
@pikachu0310 pikachu0310 requested review from goccy, utahta and shuheiktgw and removed request for goccy October 2, 2024 03:55
@pikachu0310 pikachu0310 added the cel label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Code Metrics Report

main (04088ed) #247 (3f89b04) +/-
Coverage 66.3% 66.4% +0.1%
Code to Test Ratio 1:0.4 1:0.4 +0.0
Test Execution Time 8m27s 8m4s -23s
Details
  |                     | main (04088ed) | #247 (3f89b04) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          66.3% |          66.4% | +0.1% |
  |   Files             |             76 |             76 |     0 |
  |   Lines             |          12557 |          12632 |   +75 |
+ |   Covered           |           8320 |           8384 |   +64 |
+ | Code to Test Ratio  |          1:0.4 |          1:0.4 |  +0.0 |
  |   Code              |          39019 |          39390 |  +371 |
+ |   Test              |          14665 |          15369 |  +704 |
+ | Test Execution Time |          8m27s |           8m4s |  -23s |

Code coverage of files in pull request scope (97.2% → 91.1%)

Files Coverage +/-
grpc/federation/cel/strings.go 91.1% -6.1%

Reported by octocov

Copy link
Member

@utahta utahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@pikachu0310 pikachu0310 merged commit c188207 into main Oct 4, 2024
4 checks passed
@shuheiktgw shuheiktgw deleted the strconv branch October 4, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants