Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning about file import #240

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Show warning about file import #240

merged 3 commits into from
Aug 23, 2024

Conversation

utahta
Copy link
Member

@utahta utahta commented Aug 23, 2024

Show the warning in the following cases:

  • If proto file is imported by grpc.federation.file.import statement and unused for the definition of grpc federation:
    • Import example.proto is unused for the definition of grpc federation.
  • If proto file is imported by protobuf statement and used only for the definition of grpc federation:
    • Import example.proto is used only for the definition of grpc federation. You can use grpc.federation.file.import instead.

@utahta utahta force-pushed the show-warning-file-import branch from c7e6ef0 to 1d0d9ea Compare August 23, 2024 05:43

This comment has been minimized.

@utahta utahta force-pushed the show-warning-file-import branch from 57b889a to 2b52501 Compare August 23, 2024 07:42
Copy link

Code Metrics Report

main (5b6a227) #240 (d6d00b5) +/-
Coverage 65.5% 66.1% +0.6%
Code to Test Ratio 1:0.3 1:0.3 -0.0
Test Execution Time 7m10s 7m13s +3s
Details
  |                     | main (5b6a227) | #240 (d6d00b5) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.5% |          66.1% | +0.6% |
  |   Files             |             71 |             72 |    +1 |
  |   Lines             |          11990 |          12152 |  +162 |
+ |   Covered           |           7850 |           8028 |  +178 |
- | Code to Test Ratio  |          1:0.3 |          1:0.3 |  -0.0 |
  |   Code              |          37291 |          37595 |  +304 |
- |   Test              |          13000 |          12986 |   -14 |
- | Test Execution Time |          7m10s |          7m13s |   +3s |

Code coverage of files in pull request scope (71.5% → 72.9%)

Files Coverage +/-
compiler/compiler.go 80.8% +1.0%
generator/generator.go 24.3% +0.6%
grpc/federation/cel/bind.go 100.0% +6.1%
grpc/federation/cel/conv.go 93.8% +93.8%
internal/testutil/cmpopt.go 100.0% 0.0%
lsp/server/definition.go 63.6% +0.4%
resolver/context.go 87.5% +2.5%
resolver/error.go 65.2% +1.6%
resolver/resolver.go 83.1% +0.8%
resolver/types.go 86.7% 0.0%

Reported by octocov

Copy link
Member

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !!! LGTM 👍

@utahta utahta merged commit 8128e53 into main Aug 23, 2024
4 checks passed
@utahta utahta deleted the show-warning-file-import branch August 23, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants