fix asTime api

mercari · Aug 21, 2024 · 6186ab6 · 6186ab6
1 parent adf6a0e
commit 6186ab6
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/grpc/federation/cel/time.go b/grpc/federation/cel/time.go
@@ -432,7 +432,7 @@ func (lib *TimeLibrary) CompileOptions() []cel.EnvOption {
 			"asTime",
 			MemberOverloadFunc(createTimeID("asTime_timestamp_int_time"), cel.TimestampType, []*cel.Type{}, TimeType,
 				func(_ context.Context, self ref.Val, args ...ref.Val) ref.Val {
-					return lib.toTimeValue(self.(*types.Timestamp).Time)
+					return lib.toTimeValue(self.(types.Timestamp).Time)
 				},
 			),
 		),

diff --git a/grpc/federation/cel/time_test.go b/grpc/federation/cel/time_test.go
@@ -1365,6 +1365,22 @@ func TestTime(t *testing.T) {
 				return nil
 			},
 		},
+		{
+			name: "asTime",
+			expr: "google.protobuf.Timestamp{seconds: 1560000000}.asTime()",
+			cmp: func(got ref.Val) error {
+				gotV, ok := got.Value().(*cellib.Time)
+				if !ok {
+					return fmt.Errorf("invalid result type: %T", got)
+				}
+				gotSecond := gotV.GetTimestamp().GetSeconds()
+				expected := 1560000000
+				if diff := cmp.Diff(int(gotSecond), expected); diff != "" {
+					return fmt.Errorf("(-got, +want)\n%s", diff)
+				}
+				return nil
+			},
+		},
 	}
 	reg, err := types.NewRegistry(new(cellib.Time), new(cellib.Location))
 	if err != nil {