No save historical messages in DB (#170)

mercadona · Nov 25, 2022 · 0b0dbad · 0b0dbad
1 parent 2de1377
commit 0b0dbad
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 18 deletions.
diff --git a/lib/postoffice/workers/http.ex b/lib/postoffice/workers/http.ex
@@ -45,14 +45,6 @@ defmodule Postoffice.Workers.Http do
           target: target
         )
 
-        {:ok, _data} =
-          HistoricalData.create_sent_messages(%{
-            message_id: message_id,
-            consumer_id: consumer_id,
-            payload: historical_payload,
-            attributes: attributes
-          })
-
         historical_pubsub_args = %{
           "consumer_id" => consumer_id,
           "target" => Application.get_env(:postoffice, :pubsub_historical_topic_name),

diff --git a/lib/postoffice/workers/pubsub.ex b/lib/postoffice/workers/pubsub.ex
@@ -40,14 +40,6 @@ defmodule Postoffice.Workers.Pubsub do
           target: target
         )
 
-        {:ok, _data} =
-          HistoricalData.create_sent_messages(%{
-            message_id: message_id,
-            consumer_id: consumer_id,
-            payload: historical_payload,
-            attributes: attributes
-          })
-
         historical_pubsub_args = %{
           "consumer_id" => consumer_id,
           "target" => Application.get_env(:postoffice, :pubsub_historical_topic_name),

diff --git a/test/postoffice/http_worker_test.exs b/test/postoffice/http_worker_test.exs
@@ -91,7 +91,7 @@ defmodule Postoffice.HttpWorkerTest do
       end)
 
       perform_job(HttpWorker, args)
-      assert Kernel.length(HistoricalData.list_sent_messages()) == 1
+      assert Kernel.length(HistoricalData.list_sent_messages()) == 0
 
     end
 

diff --git a/test/postoffice/pubsub_worker_test.exs b/test/postoffice/pubsub_worker_test.exs
@@ -68,7 +68,7 @@ defmodule Postoffice.PubsubWorkerTest do
       end)
 
       perform_job(PubsubWorker, args)
-      assert Kernel.length(HistoricalData.list_sent_messages()) == 1
+      assert Kernel.length(HistoricalData.list_sent_messages()) == 0
     end
 
     test "messages can be sent in bulk" do
-Original file line number
+Diff line change
@@ Expand Up / @@ -91,7 +91,7 @@ defmodule Postoffice.HttpWorkerTest do @@
           end)
           perform_job(HttpWorker, args)
-          assert Kernel.length(HistoricalData.list_sent_messages()) == 1
+          assert Kernel.length(HistoricalData.list_sent_messages()) == 0
         end
@@ Expand Down @@