Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websphere/ihs 90518 #69

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Websphere/ihs 90518 #69

merged 4 commits into from
Feb 8, 2024

Conversation

romakarol
Copy link
Contributor

@romakarol romakarol commented Feb 6, 2024

Summary

Add version files for ihs and websphere v...18
Changes are updating existing vars from version file 17 to point to new uploads on artifactory by uploaded by fergal.

PID retrieved by cracking open some of the zips and comparing 17 to 18 for the filenames containing the PID.

Story

https://github.com/spm-devops/transformers/issues/932

Test

image

Tested locally with ansible-playbook -i ./hosts --become --private-key=/Users/romakarol/.ssh/id_main_slave_rsa ./play.yml -e ' websphere_version=9.0.5.18 ihs_version=9.0.5.18 ant_version=1.10.6 ' -e artifactory_token=***

image image

Copy link
Contributor

@ourboy ourboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in the galaxy.yml you need to update the version
  • update the converge for both IHS and WAS to be the latest version
  • update molecule/iim-191-rockylinux8/converge.yml
  • was IIM not updated?
  • update roles/ihs/README.md

@romakarol
Copy link
Contributor Author

romakarol commented Feb 6, 2024

Nothing in the story about IIM, Ill see what was uploaded/needs to be updated.
The rest is done except the IIM converge, I need to match that to whatever Ill add now.

Dont see the value in updating IHS README - it is half-updated half-not. I did it for now maybe we can consider just pointing it to the latest var file instead of copying the same info over.

@romakarol
Copy link
Contributor Author

Its actually silly how many places I needed to change with that second commit, we should centralise these to only change in 1 place. One for the retro!

@romakarol romakarol merged commit d490a6a into main Feb 8, 2024
8 checks passed
@romakarol romakarol deleted the websphere/ihs-90518 branch February 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants