Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOO-1679-main | fix: the accesibility role has been changed to radio instead of button #210

Merged
merged 3 commits into from
Dec 12, 2024
Merged

MOO-1679-main | fix: the accesibility role has been changed to radio instead of button #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
652be09
fix: the accesibility role has been changed to radio instead of button
karahanharunn Dec 9, 2024
9a1d565
chore: the snapshot were updated
karahanharunn Dec 11, 2024
f0b9c4e
Merge branch 'main' into fix/MOO-1679-accessiblityRadioButton-main
karahanharunn Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/radio-buttons-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- The accessibility role has been changed to radio.

## [1.1.0] - 2024-12-3

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/radio-buttons-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "radio-buttons-native",
"widgetName": "RadioButtons",
"version": "1.1.0",
"version": "1.2.0",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
10 changes: 10 additions & 0 deletions ...ggableWidgets/radio-buttons-native/src/__tests__/__snapshots__/RadioButtons.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ exports[`Radio buttons render correctly with show label false 1`] = `
style={false}
>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -92,6 +93,7 @@ exports[`Radio buttons render correctly with show label false 1`] = `
</Text>
</View>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -186,6 +188,7 @@ exports[`Radio buttons render correctly without label 1`] = `
style={false}
>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -269,6 +272,7 @@ exports[`Radio buttons render correctly without label 1`] = `
</Text>
</View>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -365,6 +369,7 @@ exports[`Radio buttons render disabled radio buttons correctly 1`] = `
style={false}
>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -439,6 +444,7 @@ exports[`Radio buttons render disabled radio buttons correctly 1`] = `
</Text>
</View>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -543,6 +549,7 @@ exports[`Radio buttons render horizontal radio buttons correctly 1`] = `
}
>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -629,6 +636,7 @@ exports[`Radio buttons render horizontal radio buttons correctly 1`] = `
</Text>
</View>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -728,6 +736,7 @@ exports[`Radio buttons render vertical radio buttons correctly 1`] = `
style={false}
>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down Expand Up @@ -811,6 +820,7 @@ exports[`Radio buttons render vertical radio buttons correctly 1`] = `
</Text>
</View>
<View
accessibilityRole="radio"
accessibilityState={
{
"busy": undefined,
Expand Down
1 change: 1 addition & 0 deletions packages/pluggableWidgets/radio-buttons-native/src/components/RadioButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export function RadioButton({
]}
onPress={() => onSelect(name)}
testID={`radio-button-${name}`}
accessibilityRole="radio"
>
<View style={[styles.circularButtonStyle, disabled && styles.circularBtnDisabledStyle]}>
{active && <View style={styles.activeButtonStyle} />}
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/radio-buttons-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="RadioButtons" version="1.1.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="RadioButtons" version="1.2.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="RadioButtons.xml" />
</widgetFiles>
Expand Down
Loading