Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for OQL #8431

Open
wants to merge 79 commits into
base: development
Choose a base branch
from
Open

Conversation

dahfjkg
Copy link
Contributor

@dahfjkg dahfjkg commented Oct 4, 2024

This is the documentation for OQL following the new structure.

It contains the original Clauses PR and changes from OQL expressions and OQL expression syntax

content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/data/oql/oql-clauses.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part way through the review
Just noting here that I've moved the document to match the structure we discussed in Confluence. Will continue working on this tomorrow.

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dahfjkg and @pijuskri
I have done some proofreading in these commits: https://github.com/mendix/docs/pull/8431/files/8786adfd64abf1412b116d6433dd8457a11e7712..239aebdb960b3c3a018fedc47c43b47f5021afb3.

I have also made various suggestions in some comments.

Can you have a look at what I've done so far and see if you think I'm on the right track. We can discuss it further in a call if we need to discuss my changes.

If any of your earlier discussions are resolved can you mark them as resolved so it is clear what is still to do?

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a bit further, but still have only got as far as JOIN.
Sorry this is taking so long - need to do other things at the same time!

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,
I've nearly finished my review. Sorry it is taking so long, but I keep being called away to do other things.
I have a couple more questions which are related to parts of the text. See below:

@sbont sbont mentioned this pull request Dec 11, 2024
Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work on this.
I will approve now, as I have no outstanding questions. But please let me know if you want to add anything else, or if this fails to get into 10.19.😀

* Long
* Integer

If any side of the operation is of a non-numeric type, no casting is performed, and the result is handled by the , as in OQL v1. See [Expression syntax](/refguide/oql-expression-syntax/#type-coercion) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a missing word after the result is handled by the . @dahfjkg was it supposed to be "database"?

@pijuskri
Copy link
Contributor

pijuskri commented Jan 8, 2025

Since this PR is ready to be merged, for new content I created a separate PR targeting the oql-clauses branch on Pavels repository.
https://github.com/dahfjkg/docs/pull/3/files

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition. Have made a couple of proposals for changing the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants