Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate 'length' parameter in Hash java action #149

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Deprecate 'length' parameter in Hash java action #149

merged 1 commit into from
Jan 6, 2025

Conversation

serg-firsov
Copy link
Contributor

No description provided.

@atennapel
Copy link
Contributor

  • Please update the "Documentation" of the hash Java action.
  • Capitalize "Java" in the description of the "length" parameter.
  • Update the version number in the .mpr (the "_Version 10.0.7" folder in Studio Pro)
  • Release note suggested addition: "The length of the hash will now always be 32 bytes, represented as 64 hex characters."

@serg-firsov serg-firsov force-pushed the 4016-deprecate-hash-length-parameter branch from a4fdd95 to 6dc7a29 Compare December 30, 2024 16:12
@atennapel
Copy link
Contributor

atennapel commented Jan 2, 2025 •
edited
Loading

Still missing:

  • Please update the "Documentation" of the hash Java action.

And I think maybe we should use version 10.1.0, since the changes are technically a breaking change.

@serg-firsov serg-firsov force-pushed the 4016-deprecate-hash-length-parameter branch from 6dc7a29 to 8631939 Compare January 6, 2025 10:56
@atennapel
Copy link
Contributor

Approved

@serg-firsov serg-firsov merged commit 55e1eda into master Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serg-firsov @atennapel