feat: refactored participant request (team, member) service #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@navneethkrish is attempting to deploy a commit to the Protocol Labs Spaceport team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
navneethkrish
force-pushed
the
feat/participant-request-refactor
branch
5 times, most recently
from
51e6f55 to
0cb2058
Compare
navneethkrish
force-pushed
the
develop
branch
2 times, most recently
from
3253319 to
cda4f01
Compare
navneethkrish
force-pushed
the
feat/participant-request-refactor
branch
from
0cb2058 to
5dd455d
Compare
navneethkrish
force-pushed
the
feat/participant-request-refactor
branch
4 times, most recently
from
cbb4e18 to
7351eaf
Compare
madan-ideas2it
requested changes
Oct 29, 2024
| imports: [CacheModule.register()], | ||
| controllers: [AdminController], | ||
| imports: [CacheModule.register(), ParticipantsRequestModule, SharedModule], | ||
| controllers: [AdminParticipantsRequestController, AdminAuthController], |
There was a problem hiding this comment.
name can be simply ParticipantsRequestController
| } | ||
| console.log('generating token.....'); | ||
| this.logger.info('Generating admin access token...'); |
There was a problem hiding this comment.
can add some context like username
| ): Promise<any> { | ||
| const participantRequest: ParticipantsRequest | null = await this.participantsRequestService.findOneByUid(uid); | ||
| if (!participantRequest) { | ||
| throw new NotFoundException('Request not found'); |
There was a problem hiding this comment.
Change as Participant Request no found
| !requestor.isDirectoryAdmin && | ||
| referenceUid !== requestor.uid | ||
| ) { | ||
| throw new ForbiddenException(`Member isn't authorized to update the member`); |
There was a problem hiding this comment.
can we implement/reuse any guards for this at the controller level?
| } | ||
| let isMemberAvailable = await this.membersService.isMemberExistForEmailId(oldEmailId); | ||
| if (!isMemberAvailable) { | ||
| throw new ForbiddenException('Your email seems to have been updated recently. Please login and try again'); |
There was a problem hiding this comment.
Please login and try again with your updated email
| * @param member - The member object. | ||
| * @returns True if the member is a directory admin, false otherwise. | ||
| */ | ||
| checkIfAdminUser(member): boolean { |
| * @param tx - Optional transaction client. | ||
| * @returns Updated member object if a change was made, otherwise the original member object. | ||
| */ | ||
| async updateTelegramIfChanged( |
There was a problem hiding this comment.
You already have updateFieldIfChanged - can we resuse that?
| * @param tx - Optional transaction client. | ||
| * @returns Updated member object if a change was made, otherwise the original member object. | ||
| */ | ||
| async updateOfficeHoursIfChanged( |
There was a problem hiding this comment.
same comment as telegram
| }); | ||
| } else if ( |
There was a problem hiding this comment.
why slack config logic removed?
| @@ -13,7 +13,7 @@ export class SetupService { | |||
| winston.format.timestamp(), | |||
| winston.format.ms(), | |||
| winston.format.printf((info) => { | |||
| return `${info.timestamp} : ${info.level} - ${info.message}`; | |||
| return `${JSON.stringify(info)}`;; | |||
navneethkrish
force-pushed
the
feat/participant-request-refactor
branch
from
7351eaf to
642f9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a few lines describing your changes
Tickets
Checklist before requesting a review