Fix: Node/edge getter performance issue

memgraph · Jul 12, 2024 · aad6a2e · aad6a2e
1 parent e9133e5
commit aad6a2e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/models/edge.ts b/src/models/edge.ts
@@ -218,15 +218,18 @@ abstract class Edge<N extends INodeBase, E extends IEdgeBase> extends Subject im
   }
 
   getData(): E {
-    return structuredClone(this._data);
+    // no shallow/deep copy here due to the performance issues
+    return this._data;
   }
 
   getPosition(): IEdgePosition {
-    return structuredClone(this._position);
+    // no shallow/deep copy here due to the performance issues
+    return this._position;
   }
 
   getStyle(): IEdgeStyle {
-    return structuredClone(this._style);
+    // no shallow/deep copy here due to the performance issues
+    return this._style;
   }
 
   getState(): number {

diff --git a/src/models/node.ts b/src/models/node.ts
@@ -182,15 +182,18 @@ export class Node<N extends INodeBase, E extends IEdgeBase> extends Subject impl
   }
 
   getData(): N {
-    return structuredClone(this._data);
+    // no shallow/deep copy here due to the performance issues
+    return this._data;
   }
 
   getPosition(): INodePosition {
-    return structuredClone(this._position);
+    // no shallow/deep copy here due to the performance issues
+    return this._position;
   }
 
   getStyle(): INodeStyle {
-    return structuredClone(this._style);
+    // no shallow/deep copy here due to the performance issues
+    return this._style;
   }
 
   getState(): number {