Add HA secrets #93
Merged
Add HA secrets #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antejavor
requested changes
Dec 11, 2024
as51340
reviewed
Dec 12, 2024
There was a problem hiding this comment.
secrets should be under memgraph. Doesn't make sense that we have values.secrets and values.memgraph.env. Everything should be under same env part of values.yaml.
@Josipmrden or @antejavor please make a PR and fix this
|
Good thinking, @as51340, I have opened a related issue for this comment, since we released this already without the docs in a fast-paced matter because of the nature of this request. I will fix it before the next release, since I guess not that critical. Wdyt @as51340? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add environment flags for USER and PASSWORD for HA Helm Charts